Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated package_reference/inference_types.md to Korean #2171

Merged
merged 9 commits into from
Apr 19, 2024
Merged

🌐 [i18n-KO] Translated package_reference/inference_types.md to Korean #2171

merged 9 commits into from
Apr 19, 2024

Conversation

fabxoe
Copy link
Contributor

@fabxoe fabxoe commented Mar 29, 2024

What does this PR do?

Translated the package_reference/inference_types.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@fabxoe fabxoe changed the title 🌐 [i18n-KO] Translated reference/inference_types.md to Korean 🌐 [i18n-KO] Translated package_reference/inference_types.md to Korean Mar 29, 2024
Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

누락된 단어가 있어 이 부분만 추가하였습니다. 좋은 번역 감사합니다!

docs/source/ko/package_reference/inference_types.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/inference_types.md Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@boyunJang boyunJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 수고하셨습니다! 번역이 잘 되어있어서 타입 관련된 부분만 조금씩 수정했습니다:)

docs/source/ko/package_reference/inference_types.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/inference_types.md Outdated Show resolved Hide resolved
fabxoe and others added 2 commits April 13, 2024 00:41
Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com>
Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
@fabxoe fabxoe marked this pull request as ready for review April 12, 2024 15:45



## audio_classification[[huggingface_hub.AudioClassificationInput]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Wauplin !
Should we translate the task name (ex. audio_classification) in the heading or leave it as is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I think you can either keep them in English since these are "constrained" tags. Or have both the Korean + English versions in the same title like audio-classification (오디오 분류) [[huggingface_hub.AudioClassificationInput]] (disclaimer: translated with google translate).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabxoe님은 둘 중에 어떤 방법으로 하는 게 좋다고 생각하시나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jungnerd 님,
결국에는 제 생각에는 그대로 두는것도 나쁘지 않아보입니다.

해당 부분의 원래 의도는 네이밍을 공유하는 비슷한 기능의 클래스들을 나열해 두고 네이밍의 공통 부분을 표현하기 위해서 대략 snake style로 작성된 것으로 보입니다.

class huggingface_hub.DocumentQuestionAnsweringInput
class huggingface_hub.DocumentQuestionAnsweringInputData
class huggingface_hub.DocumentQuestionAnsweringOutputElement

이 클래스들의 타입명은 'document_question_answering' 로 단순한데 이대로 가독성이 좋습니다.
이것을 한글로 번역할 때 의미를 전달하고자 하는 의도였다면 '문서 질문 답변' 처럼 그대로 단순 번역이 되어 이해에 추가적인 도움이 되지는 않을 것 같습니다.
시각적인 의도라면 영어와 한글을 병기시 우측의 toctree의 메뉴의 너비도 커지지 않을까 합니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요! 성민님의 의견에 동의합니다 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wauplin After your suggestion, we've been thinking about it and we think it's better to leave the task name untranslated. Thank you for the idea!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as well. Thanks for iterating on it!

@jungnerd
Copy link
Contributor

@Wauplin LGTM! This PR is ready to merge 🚀

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@Wauplin Wauplin merged commit 8b2c746 into huggingface:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants