Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated package_reference/hf_file_system.md to Korean #2174

Merged

Conversation

SeungAhSon
Copy link
Contributor

@SeungAhSon SeungAhSon commented Mar 30, 2024

What does this PR do?

Translated the package_reference/hf_file_system.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@SeungAhSon SeungAhSon changed the title Ko package reference/hf file system.md 🌐 [i18n-KO] Translated package_reference/hf_file_system.md to Korean 🌐 [i18n-KO] Translated package_reference/hf_file_system.md to Korean Mar 30, 2024
Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다. TocTree 부분 수정하였습니다!

docs/source/ko/package_reference/hf_file_system.md Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@SeungAhSon SeungAhSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: manual edits

docs/source/ko/package_reference/hf_file_system.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/hf_file_system.md Outdated Show resolved Hide resolved
fix: resolve suggestion
@SeungAhSon SeungAhSon marked this pull request as ready for review April 28, 2024 12:26
@SeungAhSon SeungAhSon marked this pull request as draft April 28, 2024 12:28
@SeungAhSon SeungAhSon marked this pull request as ready for review April 28, 2024 12:42
@heuristicwave
Copy link
Contributor

@Wauplin I've reviewed this PR, and it looks good to me.
Would you mind merging this PR, please?

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! 🙏 🎉

@Wauplin Wauplin merged commit aeb148c into huggingface:main May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants