Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hf_api: add field 'sharded: Optional[bool]' #2188

Closed
wants to merge 1 commit into from

Conversation

heeres
Copy link

@heeres heeres commented Apr 2, 2024

to match recent update of huggingface.co/api/models output

@Wauplin
Copy link
Contributor

Wauplin commented Apr 2, 2024

Hi @heeres, thanks for the PR! I actually also pushed a PR to fix it (#2190) without seen your existing PR. Mind if I close your PR as duplicate? (in #2190 I made sure to be future-proof by removing the **kwargs when instantiating SafetensorsInfo)

@heeres
Copy link
Author

heeres commented Apr 2, 2024

No need to apply these fixes I think, as it seems the field has been removed again server-side.

@heeres heeres closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants