Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to _send_telemetry_in_thread explaining it should not be removed #2264

Merged
merged 3 commits into from
May 3, 2024

Conversation

freddyaboulton
Copy link
Contributor

No description provided.

@freddyaboulton freddyaboulton requested a review from Wauplin May 2, 2024 17:42
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

"""Contains the actual data sending data to the Hub."""
"""Contains the actual data sending data to the Hub.

This function is called directly in gradio's analytics because
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it gradio's analytics or only gradio lite? Can you also add a link to the
Gradio issue as a comment? Thanks a lot!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's gradio's !

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @freddyaboulton!

@Wauplin Wauplin merged commit 2a98fb5 into main May 3, 2024
16 checks passed
@Wauplin Wauplin deleted the add-send-telemetry-in-thread-comment branch May 3, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants