Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows tests (git security update) #2296

Merged
merged 1 commit into from
May 30, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented May 30, 2024

3 git tests are currently failing on the Windows CI with error:

fatal: active post-checkout hook found during git clone:

I seems to be due to a recent git security update that is not yet handled by git+lfs. See:

In the meantime a solution is to disable this new security feature by setting GIT_CLONE_PROTECTION_ACTIVE=false in the Windows test env. This only affects the CI, not the package itself.

Expectation

CI should be green :)

@Wauplin Wauplin requested a review from LysandreJik May 30, 2024 09:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin
Copy link
Contributor Author

Wauplin commented May 30, 2024

Merging it now since CI is green + it only affects tests.

@Wauplin Wauplin merged commit 2b2ab8b into main May 30, 2024
16 checks passed
@Wauplin Wauplin deleted the fix-windows-test-git-security-update branch May 30, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants