Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send model_id in ChatCompletion request #2302

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented May 31, 2024

This PR adds a model_id parameter to the InferenceClient.chat_completion method to be sent in the request payload. Solves #2293 cc @anubhavrana

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Wauplin
Copy link
Contributor Author

Wauplin commented Jun 4, 2024

Thanks for the review! @LysandreJik

@Wauplin Wauplin merged commit 4a6ab99 into main Jun 4, 2024
16 checks passed
@Wauplin Wauplin deleted the 2293-add-model-id-for-chat-completion branch June 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants