Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource_group_id in create_repo #2324

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jun 11, 2024

Related to slack thread (private). cc @nbroad1881 @coyotte508

Resource groups is a Enterprise feature that allows orgs to manage which members have access to a resource. This PR adds support for resource_group_id: Optional[str] in create_repo. When passed, the repo will be created inside the corresponding resource group. Check out https://huggingface.co/docs/hub/en/security-resource-groups for more details about resource groups.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but just making sure, has there been any actual customer need for this?

(we can discuss on slack 🙂)

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MoritzLaurer
Copy link
Contributor

A customer just told me that they were looking exactly for this and this PR solved their problem 👍

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implem @Wauplin

@julien-c julien-c merged commit 67686d6 into main Jun 24, 2024
17 checks passed
@julien-c julien-c deleted the create-repo-in-resource-group branch June 24, 2024 11:36
MoritzLaurer pushed a commit to MoritzLaurer/huggingface_hub that referenced this pull request Jul 3, 2024
* Support resource_group_id in create_repo

* docs

* as tip

* typoe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants