Hot-fix: do not share tags between ModelHubMixin siblings
#2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
good catch |
LysandreJik
approved these changes
Jul 16, 2024
|
Thanks for the quick reviews! |
Wauplin
deleted the
hot-fix-do-not-share-tags-in-model-hub-mixin-siblings
branch
Wauplin
added a commit
that referenced
this pull request
Jul 16, 2024
* Hot-fix: do not share tags between ModelHubMixin sibligs * reference regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a quite major issue with tags/metadata being shared between classes that inherit from
PyTorchModelHubMixin. It has most likely been introduced in #2305 which was fixing attributes lost in inheritance. This time we should be fine!I also made a modification so that tags are now deduplicated and sorted.
Realized this while working on state-spaces/mamba#471. I'll make a hot-fix release once merged as it's quite problematic. If a user has several classes inheriting from
PyTorchModelHubMixin(typically several packages using it installed in a venv), then the pushed models will have incorrect metadata on the Hub. I realized this while pushing 6d4b46a.EDIT: failing tests are unrelated