Warn if user tries to upload a parquet file to a model repo #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I don't think I'm the one that made that suggestion x) |
|
Ah yes indeed I misread 😄 I was the one to suggest it here and you suggested to recommend large-upload when uploading large datasets (in here). I'll add the second recommendation in a future PR. |
|
|
LysandreJik
approved these changes
Jul 24, 2024
|
It's niche yeah, but will hopefully save some support time ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little QoL suggested by @coyotte508 on slack.
We've had several users reporting that they've pushed their dataset to a model repo. It is then impossible to convert the repo to dataset on the Hub, forcing them to entirely re-upload everything. This PR tries to prevent this kind of mistake by raising a warning when user does upload an arrow or a parquet file to a non-dataset repo. If the user don't stop the process, the files are still correctly uploaded since we don't want to forbid the upload.