List organizations in get_user_overview
#2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
julien-c
approved these changes
Jul 19, 2024
osanseviero
approved these changes
Jul 19, 2024
| self.user_type = kwargs.pop("type", None) | ||
| self.is_following = kwargs.pop("isFollowing", None) | ||
| self.details = kwargs.pop("details", None) | ||
| self.orgs = [Organization(**org) for org in kwargs.pop("orgs", [])] |
There was a problem hiding this comment.
To add to User class docstring
There was a problem hiding this comment.
Addressed in fe04844
|
Thanks for the quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR after server-side update (https://github.com/huggingface-internal/moon-landing/pull/10607, private link). See also discussion in slack (private link).
This PR handles
orgsinget_user_overview. It is anOrganizationdataclass (newly defined) with avatar_url, name and fullname.I also realized we forgot to expose
get_user_overviewat the root of the package. This PR fixed this. Also exposingModelInfo,DatasetInfoandSpaceInfothat I wanted to add since quite some time.