Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat completion url for OpenAI compatibility #2418

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jul 24, 2024

Fix #2414. Thanks @alvarobartt for reporting. The implemented solution will work both when /v1 is provided (openai compatibility) and without (backward compatibility). Trailing "/" are also silently ignored.

EDIT: failing tests are unrelated (torch update)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Wauplin! 🤗

@Wauplin Wauplin merged commit 4706917 into main Jul 29, 2024
15 of 17 checks passed
@Wauplin Wauplin deleted the 2414-fix-chat-completion-url-v1 branch July 29, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InferenceClient alignment with base_url as in OpenAI client
3 participants