Do not raise if chmod fails #2429
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
XciD
approved these changes
Jul 31, 2024
Wauplin
added a commit
that referenced
this pull request
Jul 31, 2024
* Do not raise if chmod fails * just to test * test * comments
|
Made a hot-fix release for this: https://github.com/huggingface/huggingface_hub/releases/tag/v0.24.4. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implementation from #1220.
When downloading a file, we set the correct permissions on it when applicable. However if it's not possible, we shouldn't raise an exception. This PR fixes this by ignoring any OSError in the process and convert them to a warning log.
Moreover, if copying a file with
shutils.copy2cannot be done (copy file + metadata), we default toshutils.copyfile(copy file content). What's important is to have the file content on the destination path rather than the metadata.cc @XciD who got this while working on an S3 mount
EDIT: failing test is unrelated