Define cache errors in errors.py

[010kim]

Below is the list of descriptions for this PR.

1. Defined two errors (CacheNotFound, CorruptedCacheExcpetion) in errors.py

• imported typing and pathlib package to keep the original definition of CacheNotFound

2. Adjusted the import paths in init.py

3. Removed the original definitions of the errors in _cache_manager.py

• added "from huggingface_hub.errors import CacheNotFound, CorruptedCacheException" for API support

#2069

[010kim]

@Wauplin Hello! I have a question about the definition for CacheNotFound class. I imported pathlib and typing packages in errors.py to keep the original definition of CacheNotFound. But I found in the previous comments of yours that you want to keep errors.py as simple as possible. Do you have any suggestions?

[Wauplin]

That's perfect, thanks!

I imported pathlib and typing packages in errors.py to keep the original definition of CacheNotFound. But I found in the previous comments of yours that you want to keep errors.py as simple as possible. Do you have any suggestions?

What I meant in #2069 (comment) is that we should not add logic to errors.py (for example, logic to raise an error from a failed requests.Response. However, it's perfectly fine to import standard modules. What would be annoying would be to have from huggingface_hub.... import ... in errors.py (which is unnecessary and can cause circular imports issues)

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[Wauplin]

There seems to be styling issues. Could you install dev dependencies locally (see here) and then run make style (see here) to fix them. You can then test with make quality and commit the changes.

[010kim]

I closed the PR to sync with the newest main branch. I will create another PR with the original fix.

[Wauplin]

It's also possible to update click on "update branch" on the PR page to get the latest update on your branch 😉