[Inference] Support stop parameter in text-generation instead of stop_sequences
#2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Makes sense! cc @gante @ArthurZucker maybe at some point we'll want to align stop_sequences to stop if that's what's used everywhere else
osanseviero
approved these changes
Aug 26, 2024
| @@ -1655,7 +1655,8 @@ def text_generation( # type: ignore | |||
| repetition_penalty: Optional[float] = None, | |||
| return_full_text: Optional[bool] = False, # Manual default value | |||
| seed: Optional[int] = None, | |||
| stop_sequences: Optional[List[str]] = None, # Same as `stop` | |||
| stop: Optional[List[str]] = None, | |||
| stop_sequences: Optional[List[str]] = None, # Deprecated, use `stop` instead | |||
There was a problem hiding this comment.
Note that transformers now uses stop_strings but as you mention, transformers will be deployed with TGI so not big deal
There was a problem hiding this comment.
Actually this will be an issue with IE deployment if not using TGI right?
There was a problem hiding this comment.
Yes and no, it's harder than that as you found out (private gdoc)
|
Thanks both for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2471 cc @sadra-barikbin.
This PR deprecates
stop_sequencesin favor of thestopparameter for the text_generation task.Context: in both TGI and the
text_generationspecs thestopparameter is provide stop tokens to the model. However historicallytransformerswas using thestop_sequencesparameter which had been propagated to Inference API andInferenceClient. Since we are now TGI-first (i.e. eventransformersmodels are served with TGI), let's just exposestop.