Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint.update signature #2477

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Aug 21, 2024

Two parameters are missing compared to the update_inference_endpoint method: scale_to_zero_timeout and custom_image. This PR fixes it.
Reported by @MoritzLaurer in #2472 (comment).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@MoritzLaurer MoritzLaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
(I imagine that the token parameter is not necessary because the token is already in the endpoint object?)

@Wauplin
Copy link
Contributor Author

Wauplin commented Aug 21, 2024

Thanks for the review!

(I imagine that the token parameter is not necessary because the token is already in the endpoint object?)

Yes exactly, it's already passed as token=self._token.

@Wauplin Wauplin merged commit 73ee664 into main Aug 21, 2024
15 of 17 checks passed
@Wauplin Wauplin deleted the 2472-fix-endpoint-update-signature branch August 21, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants