feat: ✨ allow passing secrets to the inference endpoint client #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the secrets argument to create_inference_endpoint, update_inference_endpoint and InferenceEndpoint.update
Wauplin
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Thanks for the quick PR @LuisBlanche! I left a few minor comments, otherwise everything looks good to me :) Once those are merged and the CI is green, I think we should be good to go!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Failing tests in the CI are unrelated so let's merge this! Thanks again for the quick contribution 🤗 Your changes will be shipped in next release. In the meantime, you can already use them if you install from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #2485
Added the secrets argument to