Expose RepoUrl
info in CommitInfo
object
#2487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR exposes
repo_url
info in theCommitInfo
class. This will make it easier to retrieve the repo_id of a commit, typically whenModel.push_to_hub
creates the repo + create a commit and returns only the commit info and not the repo info (requested by @not-lain on Slack -internal- + makes sense to expose it).Note:
self.commit_url.split("/commit/")[0]
is guaranteed to succeed given this (private repo), this and this are the only occurrences where the commit url is computed.