-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all constant imports to module-level access #2489
Refactor all constant imports to module-level access #2489
Conversation
Hey @Wauplin, the required changes were done in this PR. And there is a |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this work @WizKnight! Everything looks good to me now and will close #1172 for good :) Thanks again for the contribution 🤗
Thankyou, @Wauplin🤗!!! I appreciate your guidance and patience throughout this process. I've learned a lot from you, especially about handling those little mistakes. I'm excited to take on new challenges and would be grateful if you could assign me another task. |
Hi @WizKnight, glad you took out some learning in the process! Would you be interested in having a look at #2447 for example? It's about adding support for a new endpoint in |
This PR addresses issue #1172 by refactoring constant imports throughout the Hugging Face Hub codebase. It introduces module-level access
(from ... import constants)
for improved code organization and maintainability.Key changes:
from . import constants
in all relevant files.(e.g., constants.ENDPOINT)
.