Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add
update_repo_settings
function to HfApi #2447 #2502[Feature] Add
update_repo_settings
function to HfApi #2447 #2502Changes from 20 commits
91042af
451baf1
f256710
409baa5
f773f77
92c9531
fb7cfd1
cf3c78c
6e81211
2544898
22952bf
609ea61
3e507a9
761a33d
6d57808
401502f
244e4b2
12e0eb5
8e6f9cf
59c05a5
8bf6f82
2bd4767
fbe8cbe
772837d
ef61fbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test was failing with a Bad Request error because
repo_type
was not specified here. This works fine for model repos, as they are the default repo type. For dataset repos, we need to explicitly provide therepo_type
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above, we need to explicitly provide
repo_type
. Also, you probably got a BadRequestError here, because the concept of "gated" repositories does not apply to spaces. Only models and datasets can be gated. For spaces, the only valid value for thegated
parameter isFalse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop the test for Space repo_type then, thanks for looking into it @hanouticelina :) Testing on model and dataset is already more than enough 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay then @Wauplin :) , I'll remove the space_repo_type test and commit again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hanouticelina, thanks for taking a look at the
space_repo_settings
test. I removed it in the latest commit, as @Wauplin recommended. Also, I addedrepo_type
todataset_repo_settings
based on your suggestion.