Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty siblings #2503

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix empty siblings #2503

merged 1 commit into from
Sep 2, 2024

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Sep 2, 2024

{model,dataset,space}_info.siblings should be [] if the repo is empty no ? currently it's None even if the Hub API returns "sibligns": [] in the JSON response

this causes unexpected though minor errors in the Viewer

e.g. it indirectly causes the histogram filtering UI of the laion's viewer to be disabled

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense yes! Thanks for the PR :)

@Wauplin Wauplin merged commit 609160f into main Sep 2, 2024
19 checks passed
@Wauplin Wauplin deleted the fix-empty-siblings branch September 2, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants