Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for trending score #2513

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 5, 2024

Related to https://github.com/huggingface-internal/moon-landing/pull/11062 (private link).

This PR adds support for the trendingScore attribute:

  • ModelInfo, DatasetInfo and SpaceInfo now have an official trending_score attribute populated when the server returns it.
  • ExpandModelProperty_T, ExpandDatasetProperty_TandExpandSpaceProperty_Tnow have atrendingScoreattribute to ask the server to return this attribute usingexpand[]=trendingScore`
  • updated some docstrings

In practice, those changes are purely cosmetic to make the attribute better supported. The ExpandXxxProperty_T are only types to help with autocompletion while the XxxInfo classes are already exposing all fields they receive from the server. This PR helps by making the autocompletion + documentation better and by converting trendingScore => trending_score as an attribute

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Wauplin!

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍 thanks @Wauplin

@Wauplin
Copy link
Contributor Author

Wauplin commented Sep 9, 2024

Thanks for the reviews! :)

@Wauplin Wauplin merged commit fe39a96 into main Sep 9, 2024
19 checks passed
@Wauplin Wauplin deleted the better-support-for-trending-score branch September 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants