http_backoff retry with SliceFileObj #2542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry mechanism of
http_backoff
doesn't work fromlfs_upload
->_upload_multi_part
->_upload_parts_iteratively path,data
is consumed after the first attempt when usingSliceFileObj
becauseio_obj_initial_pos
should be set and reset on retry,io_obj_initial_pos
is not set due toisinstance(kwargs["data"], io.IOBase)
.This PR changes the check to
isinstance(kwargs["data"], (io.IOBase, SliceFileObj))
and movesSliceFileObj
toutils._lfs
to avoid circular import:Usage of
SliceFileObj
in other areas is updated to import fromutils._lfs
.Closes #2539