Enforce parameters as a List of Dictionaries in modelinfo.safetensors #2585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies themodel_info
method to ensure that theSafeTensorsInfo
instance is initialized with a list of dictionaries for theparameters
attribute, as intended by the class definition.This PR changes the type definition of
parameters
attribute inSafeTensorsInfo
to be aDict
instead ofList[Dict[str, int]]
The model_info response for repo_id =
allenai/Molmo-72B-0924
is of the form:which is
notexpected sinceparameters
should be of typeList[Dict[str, int]]
Dict[str, int]
This PR might serve as an extension for #2190