Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests listing text generation models #2593

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Oct 8, 2024

Should fix CI now that bloom model is not served anymore.

@Wauplin Wauplin requested a review from hanouticelina October 8, 2024 14:04
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
test_add_commit_push_non_blocking_process_killed is failing and the test is unpredictable, sometimes it succeeds, sometimes not. I'm not sure but I think the process seems to be failing before the sigkill 😕

@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 8, 2024

test_add_commit_push_non_blocking_process_killed is failing and the test is unpredictable, sometimes it succeeds, sometimes not. I'm not sure but I think the process seems to be failing before the sigkill 😕

That's a bit of an annoying test. Since it's a test about the legacy Repository class, it's more than fine to just flag it as flaky (done in 24e7d2c). Let's hope it fixes the CI 🤞

@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 8, 2024

Well it did not work so I reverted. Let's merge this PR as test_add_commit_push_non_blocking_process_killed is unrelated (would still be good to have it solved)

@Wauplin Wauplin merged commit 39c7a8b into main Oct 8, 2024
18 checks passed
@Wauplin Wauplin deleted the fix-list-text-generation-models-in-tests branch October 8, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants