Remove templating utility #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
approved these changes
Oct 16, 2024
|
Ahah, don't get too used to it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean-up PR to remove any templating-related utility from
huggingface_hub.These methods/objects have been added ~6 months and have never been promoted or documented anywhere. I think it's safe to delete them without prior notice. At that point, some models were served with TGI (most of them), others with
transformers. Since TGI-served models have a/v1/chat/completion, we didn't and don't need to do client-side rendering. However, fortransformers-backed models we had to implement client-side rendering to be on-par feature-wise.Now that all conversational text-generation models in InferenceAPI are served with TGI (even when it's transformers behind the scenes), we don't use client-side templating at all. This is a clean-up PR to get read of the utilities altogether.
In theory, this is a breaking change. In practice I don't think we should care given the small-ish timeframe (a few versions) and that we never promoted them. Worth mentioning it in the release notes though.