[HfApi] Fix sorting properties in list_models(), list_datasets() and list_spaces()
#2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Nov 4, 2024
Comment on lines
+1914
to
+1922
| params["sort"] = ( | ||
| "lastModified" | ||
| if sort == "last_modified" | ||
| else "trendingScore" | ||
| if sort == "trending_score" | ||
| else "createdAt" | ||
| if sort == "created_at" | ||
| else sort | ||
| ) |
There was a problem hiding this comment.
if it ever becomes a problem again in the future we might explore having a "snake_case to camelCase" helper to fix it once and for all. Ok to keep it like this for now (at least things are clearly documented and tested).
There was a problem hiding this comment.
beware, we like inconsistency in the hub team, we might use a snake case just to trick you! 🤪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported in an internal slack message where the
created_atfield inModelInfodoes not work as a valid sort parameter for listing models via the api. the correct parameter should becreatedAtrather thancreated_at. The same issue applies to thetrending_scorefield.I’ve restricted the list of possible sort values in the docstring to match those defined on the API side, as seen here (private link). also, I'm not sure if the sorting feature is widely used, but I've added some tests just in case!