Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about upload_large_folder if really large folder #2656

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 5, 2024

Fix #2650.

Based on #2650.

If large folder (>30), we log an INFO message to suggest using upload_large_folder. With this PR if the folder is >200 files, we log as a WARNING to be sure the user knows about it (200+ files at files is likely to fail anyway...).

cc @yoinked-h

@Wauplin Wauplin requested a review from hanouticelina November 5, 2024 09:05
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Wauplin!

@Wauplin Wauplin merged commit 0deb17f into main Nov 5, 2024
17 checks passed
@Wauplin Wauplin deleted the 2650-warn-if-really-large-folder branch November 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest to use upload_large_folder when using upload_folder with folders containing many files
3 participants