Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocompletion not working with ModelHubMixin #2695

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Dec 5, 2024

Fix #2694.

Issue comes from a bad type annotation in __new__. Best to use type alias there (as done in other parts of the module already).

Added a quick test using jedi (an autocomplete tool we already use in some tests).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @Wauplin! let's merge

@hanouticelina hanouticelina merged commit 78b4e5e into main Dec 6, 2024
17 checks passed
@hanouticelina hanouticelina deleted the 2694-fix-model-hub-mixin-autocompletion branch December 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad type guess in VS Code with ModelHubMixin inheritance
3 participants