Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝Translating docs to Simplified Chinese #2705

Merged
merged 17 commits into from
Dec 13, 2024

Conversation

miaowumiaomiaowu
Copy link
Contributor

#1915
I have translated "overview.md" into Simplified Chinese. 😊

@miaowumiaomiaowu
Copy link
Contributor Author

Hi @13579606

I've translated another file into Chinese. Could you kindly take some time to review it again? I would greatly appreciate your help!
Thank you so much!😊

Copy link

@13579606 13579606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s my suggestion; I think the rest of the content looks good.🤗

docs/source/cn/guides/overview.md Outdated Show resolved Hide resolved
@miaowumiaomiaowu
Copy link
Contributor Author

@13579606 Exactly! I overlooked that point. I think you're right. I'll make the changes right away. Thank you for your feedback!

Copy link

@13579606 13579606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miaowumiaomiaowu I’ve carefully reviewed your translation file, and I didn’t find any issues. Thank you for your contribution! Please don’t worry about bothering me—it's truly my pleasure to assist you. 😊

@miaowumiaomiaowu
Copy link
Contributor Author

@13579606 I want to sincerely thank you for taking the time to review my PR. Your detailed feedback and thoughtful suggestions mean so much to me. I deeply appreciate your effort and support—it truly makes a difference! Thank you again for your invaluable help! 🙏😊

@hanouticelina
Copy link
Contributor

Hi @miaowumiaomiaowu thank you for this PR! It would be great if you could include any other documentation translations you're planning to work on in this same PR, rather than creating separate ones. 🤗

@miaowumiaomiaowu
Copy link
Contributor Author

@hanouticelina Thank you for your suggestion! I have translated the "hf_file_system.md" file into Chinese. Could you please review it again? I really appreciate your patience. 😊

@hanouticelina
Copy link
Contributor

thanks @miaowumiaomiaowu!
@13579606 would you be able to help review the translation of hf_file_system.md when you have a chance? thank you! 🤗

Copy link

@13579606 13579606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanouticelina Of course, I’m more than happy to help.😊
@miaowumiaomiaowu Thank you for your contribution! Here are a few of my suggestions for improvement.🥰

docs/source/cn/guides/hf_file_system.md Outdated Show resolved Hide resolved
@miaowumiaomiaowu
Copy link
Contributor Author

@13579606 Thank you for your suggestion! Your translation is more accurate.🥳

Copy link

@13579606 13579606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miaowumiaomiaowu Thank you for your prompt revisions! I think there are no other issues. If you need any help, I’m always here.☺️

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks again 🤗 if you're planning to work on translating any other doc to Chinese, please include them in this PR. otherwise, we can merge this PR.

@miaowumiaomiaowu
Copy link
Contributor Author

@hanouticelina I don't have any files to translate.Thank you for your time .😊

@hanouticelina hanouticelina merged commit 6be2b3e into huggingface:main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants