Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serialization] Fix: remove context manager when loading shards + handle mlx weights #2709

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

hanouticelina
Copy link
Contributor

This PR fixes some failing tests in transformers when using the hfh loading helpers introduced in #2687.

See: https://app.circleci.com/pipelines/github/huggingface/transformers/113474/workflows/1a1ecbcd-26dc-4d3e-872d-79e5aedf04f2/jobs/1516443/tests#failed-test-1

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable :)

@hanouticelina
Copy link
Contributor Author

🎉 tests are now passing in transformers : https://github.com/huggingface/transformers/runs/34374642187
(the failing tests seem unrelated).
I think we are good to merge and release :)

cc @LysandreJik

@hanouticelina hanouticelina merged commit ca3f674 into main Dec 13, 2024
17 checks passed
@hanouticelina hanouticelina deleted the fix-loading-state-dict branch December 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants