-
Notifications
You must be signed in to change notification settings - Fork 842
✨ Support for Featherless.ai as inference provider #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pohnean for the PR! it works as expected, except for the text generation task (see my comment below).
|
@bot /style |
|
Style fixes have been applied. View the workflow run here. |
|
Hi @hanouticelina, I've merged your changes in, thanks! It's ready for you to review again. Btw, I've also added an optional api_key parameter to the _prepare_mapping_info so that models can be run when in staging model. |
Co-authored-by: célina <hanouticelina@gmail.com>
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pohnean for the iteration. I left a few comments — let's avoid changing anything that's not related to the integration of Featherless AI, there is no need to pass the api_key to HfApi in _fetch_inference_provider_mapping, you don't need to be logged in to fetch model info.
This reverts commit 761553ee31e10b02105c33969e2705f24fe9a8b4.
|
Hi @hanouticelina, issues resolved. |
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks @pohnean for the PR!
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks both for integration and reviews :)
This PR implements support for Featherless.ai as an inference provider for conversional and text-generation tasks.