Skip to content

Conversation

@pohnean
Copy link
Contributor

@pohnean pohnean commented May 13, 2025

This PR implements support for Featherless.ai as an inference provider for conversional and text-generation tasks.

@pohnean pohnean changed the title ✨ Support for Featherless.ai as inference provider. ✨ Support for Featherless.ai as inference provider May 13, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pohnean for the PR! it works as expected, except for the text generation task (see my comment below).

@hanouticelina
Copy link
Contributor

@bot /style

@github-actions
Copy link
Contributor

Style fixes have been applied. View the workflow run here.

@pohnean
Copy link
Contributor Author

pohnean commented May 21, 2025

Hi @hanouticelina, I've merged your changes in, thanks! It's ready for you to review again.

Btw, I've also added an optional api_key parameter to the _prepare_mapping_info so that models can be run when in staging model.

@pohnean pohnean requested a review from hanouticelina May 21, 2025 17:28
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pohnean for the iteration. I left a few comments — let's avoid changing anything that's not related to the integration of Featherless AI, there is no need to pass the api_key to HfApi in _fetch_inference_provider_mapping, you don't need to be logged in to fetch model info.

@pohnean
Copy link
Contributor Author

pohnean commented May 22, 2025

Hi @hanouticelina, issues resolved.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @pohnean for the PR!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks both for integration and reviews :)

@hanouticelina hanouticelina merged commit 975df7f into huggingface:main May 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants