subprocess.run -> run_subprocess

[LysandreJik]

Implement a run_subprocess method to remove most of the verbosity introduced by subprocess.run

[Narsil]

This is wrong I think, you really want to pass list of arguments and not split arbitrarily.

For instance on filename containing spaces it would break:

filename = "my filename.txt, command is now: `["xxx", "my", "filename.txt"], instead of expected ["xxx", "my filename.txt"].

[julien-c]

yes!

[LysandreJik]

Thanks for the review, will adapt the draft

[sgugger]

This is so much nicer, thanks a lot for refactoring those!

[sgugger]

Why not a hard error?

[adrinjalali]

This looks quite good. Pinging @LysandreJik as a reminder.

[adrinjalali]

docstring documentation here would be nice.

[LysandreJik]

Thanks for the reminder! Would indeed like to update this and wrap this up.

[LysandreJik]

Should be good to go!

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[adrinjalali]

I've had bad experiences in including functions in __init__ files since soon it'll cause some circular import issues. Could we move this to a utils/_subprocess.py file (I don't really feel strongly about the file name)?

[LysandreJik]

Yes, sounds good. Will move it around!

[LysandreJik]

@merveenoyan are you aware of why this test might fail?

______ HubKerasFunctionalTest.test_save_pretrained_task_name_deprecation _______

self = <tests.test_keras_integration.HubKerasFunctionalTest testMethod=test_save_pretrained_task_name_deprecation>

    def test_save_pretrained_task_name_deprecation(self):
        REPO_NAME = repo_name("save")
        model = self.model_init()
        model.build((None, 2))
    
        with pytest.warns(
            FutureWarning,
            match="`task_name` input argument is removed. Pass `tags` instead.",
        ):
            save_pretrained_keras(
                model,
                f"{WORKING_REPO_DIR}/{REPO_NAME}",
                tags=["test"],
                task_name="test",
>               save_traces=True,
            )
E           Failed: DID NOT WARN. No warnings of type (<class 'FutureWarning'>,) matching ('`task_name` input argument is removed. Pass `tags` instead.') were emitted. The list of emitted warnings is: [FutureWarning('`task_name` input argument is deprecated. Pass `tags` instead.')].

Failed before and after rebasing on current main.