-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hugging Face Hub documentation README and Endpoints #527
Conversation
Also cc @stevhliu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Overall looks good but left a couple of minor comments
docs/hub/endpoints.md
Outdated
| /api/datasets/{repo_id} <br/> /api/datasets/{repo_id}/revision/{revision} <br/> GET | Get all information for a specific dataset. <br/>- `full`: Whether to fetch most dataset data, such as all tags, the files, etc. | `dataset_info(repo_id, revision)` | ```headers = { "authorization" : "Bearer $token", "full" : "full" }``` | | ||
| /api/metrics <br/> GET | Get information from all metrics in the Hub. | `list_metrics()` || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we really need this to be honest (no strong opinion), as metrics are not user-generated (unlike models and datasets and spaces) I wouldn't consider them a first class citizen of the hub
(that method is documented in datasets
though, where it's relevant to have it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My motivation with exposing it here is since there is a functional api within HfApi
for it (e.g. list_metrics
), it's in the docs that it doesn't take in params and just grabs them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julien-c kept it in for final, if we want it removed let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! I just had a question about adding some more guidance around the parameters and using consistent terms.
Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @muellerzr!
LGTM!
Feel free to merge when the code quality passes :) |
Started updating the documentation to include the latest API information.
README:
cached_download
HfApi
query methods and link to endpoint documentationEndpoints:
/api/models
and/api/datasets
to includeauthor
filter/api/metrics
main:
cc @osanseviero @LysandreJik @julien-c