Search by authors and string

[FrancescoSaverioZuppichini]

Why

Searching by authors and search (so just a string) is currently missing, linked to #513

How

I've edited the logic inside hf_api.HfApi.list_models. Pasted below for convenience

  def list_models(....):
     ....
     if filter is not None:
          params.update({"filter": filter})
          params.update({"full": True})
      if author is not None: # <- here
          params.update({"author": author})
      if search is not None: # <- here
          params.update({"search": search})
      .....

[EDIT] After discussing it we also included the same logic in list_datasets

Test it

I've added a few new lines in the tests under HfApiPublicTest, maybe a test with a complex query + authors, search is not a bad idea.

Since I've edited my main branch on the fork this branch has the commits from the main branch that contains the code for
#522. Unfortunately, I am not a git wizard so I've removed that code. I am not sure what's the best way to clean it up while having my other PR open (#522)

Thanks

Francesco

[julien-c]

The list_models-related changeset of this PR looks good to me, and you could also apply it to list_datasets which has the same API

[muellerzr]

Thank you for this!

I saw your note about some git issues, try accepting my suggestions in the review and that should handle it just fine.

I also have a few suggestions in there

[FrancescoSaverioZuppichini]

The list_models-related changeset of this PR looks good to me, and you could also apply it to list_datasets which has the same API

Changed the signature and the logic of list_datasets to match list_models :) Tests are green on my local machine

[FrancescoSaverioZuppichini]

Thank you for this!

I saw your note about some git issues, try accepting my suggestions in the review and that should handle it just fine.

I also have a few suggestions in there

Hi @muellerzr , I've included your commits, thank you for helping me out

[FrancescoSaverioZuppichini]

I've included the changes

[julien-c]

LGTM but i'll let @muellerzr and @LysandreJik chime in!

[muellerzr]

@FrancescoSaverioZuppichini looks like you're not passing the code quality tests, can you do the following please? :)

pip install -U black isort flake8

And then from the root of the repository:

make style; make quality

That should make the quality tests pass

[LysandreJik]

Looks good to me, thanks @FrancescoSaverioZuppichini!