Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test directions #547

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Add test directions #547

merged 3 commits into from
Dec 20, 2021

Conversation

muellerzr
Copy link
Contributor

Adds a small markdown file that contains directions for running the test suite, since it took me a moment to get everything setup on my side.

@muellerzr muellerzr added the documentation Improvements or additions to documentation label Dec 17, 2021
@osanseviero
Copy link
Contributor

If you do export HUGGINGFACE_CO_STAGING=1 that will impact you later unless you revert it.

One solution is to do
HUGGINGFACE_CO_STAGING pytest -sv ./tests/
and then it should work.

@osanseviero
Copy link
Contributor

osanseviero commented Dec 17, 2021 •
edited
Loading

I'm ok with going with this proposal in /tests/README/md for now, but we should consider creating a CONTRIBUTING.md for this.

@muellerzr
Copy link
Contributor Author

Should be good to go now @osanseviero :)

osanseviero
osanseviero approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@muellerzr muellerzr merged commit 829e925 into huggingface:main Dec 20, 2021
@muellerzr muellerzr deleted the test-directions branch December 20, 2021 14:58
@muellerzr muellerzr mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muellerzr @osanseviero