Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorBoard for Keras models #651

Merged
merged 16 commits into from
Feb 7, 2022
Merged

TensorBoard for Keras models #651

merged 16 commits into from
Feb 7, 2022

Conversation

merveenoyan
Copy link
Contributor

TensorBoard FTW

@osanseviero osanseviero marked this pull request as ready for review February 4, 2022 13:06
osanseviero
osanseviero reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. The tests are failing, so I left a couple of notes 😄

src/huggingface_hub/keras_mixin.py Outdated Show resolved Hide resolved
src/huggingface_hub/keras_mixin.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
src/huggingface_hub/keras_mixin.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
@merveenoyan
Copy link
Contributor Author

@osanseviero I did resolved everything

osanseviero
osanseviero approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I left one last comment to improve the test but it looks great!!

tests/test_keras_integration.py Show resolved Hide resolved
osanseviero
osanseviero approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/test_keras_integration.py Outdated Show resolved Hide resolved
merveenoyan and others added 2 commits February 4, 2022 19:01
@merveenoyan @osanseviero
Update tests/test_keras_integration.py
6c3c6a7 
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
@merveenoyan
revert
ccd364e
@merveenoyan merveenoyan merged commit b9ca731 into main Feb 7, 2022
@merveenoyan merveenoyan deleted the keras-tensorboard branch February 7, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merveenoyan @osanseviero