Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{upload|delete}_file: Remove client-side filename validation #669

Merged
merged 4 commits into from
Feb 8, 2022
Merged

{upload|delete}_file: Remove client-side filename validation #669

merged 4 commits into from
Feb 8, 2022

Conversation

SBrandeis
Copy link
Contributor

coyotte508
coyotte508 reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LysandreJik
LysandreJik approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It seems you have black==22.1, to which the CI hasn't been switched to yet, hence the failures. Should be switched to black==2.1 at the end of the week.

Pierrci
Pierrci approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@Pierrci Pierrci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SBrandeis! 👍

@SBrandeis SBrandeis merged commit 42ba950 into main Feb 8, 2022
@SBrandeis SBrandeis deleted the fix-regex-filename branch February 8, 2022 16:16
@julien-c
Copy link
Member

julien-c commented Feb 8, 2022

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 left review comments

@LysandreJik LysandreJik LysandreJik approved these changes

@Pierrci Pierrci Pierrci approved these changes

@yjernite yjernite Awaiting requested review from yjernite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SBrandeis @julien-c @coyotte508 @Pierrci @LysandreJik