Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure post_method is only executed once #676

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Ensure post_method is only executed once #676

merged 1 commit into from
Feb 9, 2022

Conversation

sgugger
Copy link
Contributor

@sgugger sgugger commented Feb 9, 2022

Currently, the post_method of a CommandInProgress is executed each time the flag is_done is accessed. This can yield to errors as seen in the Transformers CI (with some LFS pruning attempted in folders that don't exist anymore).

This PR destroys the post_method once executed, which ensures it is only executed once.

@sgugger sgugger requested a review from LysandreJik February 9, 2022 16:37
@sgugger sgugger mentioned this pull request Feb 9, 2022
Merged
LysandreJik
LysandreJik approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch :) Thanks for fixing!

@sgugger sgugger merged commit 9d0d461 into main Feb 9, 2022
@sgugger sgugger deleted the execute_post_method_once branch February 9, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgugger @LysandreJik