Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorBoard Override for same Repository #709

Merged
merged 4 commits into from
Feb 23, 2022
Merged

TensorBoard Override for same Repository #709

merged 4 commits into from
Feb 23, 2022

Conversation

merveenoyan
Copy link
Contributor

TensorBoard override enabled for when user wants to push to same repository

@merveenoyan
Copy link
Contributor Author

merveenoyan commented Feb 23, 2022 •
edited
Loading

I ran the style on my local it's so weird it's not passing

I have black 21.4b, requirement is ~=22.0

osanseviero
osanseviero reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🔥 Thanks for the PR. The PR looks good, I left minor nits and pretty much ready to merge

tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Outdated Show resolved Hide resolved
tests/test_keras_integration.py Show resolved Hide resolved
osanseviero
osanseviero approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR

@merveenoyan merveenoyan merged commit 0773518 into main Feb 23, 2022
@merveenoyan merveenoyan deleted the tensorboard_fix branch February 23, 2022 14:04
@merveenoyan merveenoyan mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merveenoyan @osanseviero