Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speechbrain library tag + code snippet #73

Merged
merged 10 commits into from
Jun 16, 2021
Merged

speechbrain library tag + code snippet #73

merged 10 commits into from
Jun 16, 2021

Conversation

osanseviero
Copy link
Contributor

No description provided.

@osanseviero osanseviero requested a review from julien-c June 4, 2021 06:46
interfaces/Libraries.ts Outdated Show resolved Hide resolved
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but let's wait for feedback from @TParcollet, @mravanelli and team! 🤗

interfaces/Libraries.ts Outdated Show resolved Hide resolved
@osanseviero osanseviero requested a review from Narsil June 7, 2021 08:50
@osanseviero
Copy link
Contributor Author

I did some changes for consistency with #94.

@TParcollet and team, do the code snippets seem appropriate for the respective models?

@TParcollet
Copy link

Yes!

@osanseviero osanseviero merged commit 9f0fd3b into main Jun 16, 2021
@osanseviero osanseviero deleted the speechbrain branch June 16, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants