-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tempfile for tensorboard logs in tensorboard tests in test_keras_integration.py #761
Conversation
Let us know whenever it's ready 😄 also try to re-run the workflow few times to make sure it works. |
CAME BACK FROM LUNCH 🥑 |
I guess here, and in a few other places in the test suite, we actually create files/folders under the working directory. Wouldn't it better to do all of those operations under |
@adrinjalali I actually saw couple of files that exist under tests/fixtures that were left (I don't know if it's on purpose). I removed my temp files directly at the end of the test instead, I can have another temporary directory if you want me to. |
Yes I've also seen files under Probably a better solution is to create everything (cloning repo, creating tensorboard logs, etc) under a folder you can get from python's tempdir module: https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir Then you don't even have to remove anything. Everytime you get a new folder, and with every reboot all those files are gone. |
something along the lines of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the PR 🚀
We should also rename the PR before merging
TensorBoard logs are in parent directory of the repository so they weren't removed along with repository, I added lines to remove them so that they don't bug tensorboard tests.