TST calling delete_repo under tempfile for fixing the test #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh interesting. Yeah this makes sense. Let's see what the CI says. |
|
@adrinjalali I removed the problematic test because it was redundant anyway, it was checking if tensorboard is pushed to Hub, meanwhile the other one checked if tensorboard was pushed and when you push another tensorboard log again if the former log was overridden. The tests pass. I think we can just merge. |
adrinjalali
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I pushed this change but it wasn't pushed and then I saw the other branch was removed because it was merged.
I couldn't reproduce the error on my local, my guess is that I was calling
delete_repoout oftempfilewhich caused the repository not found error. Hopefully this fix will work.