-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT change dev version to 0.5, 0.4 is already released #810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the change @adrinjalali!
Re-running the tests now that the inference-api rate limit was fixed. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
self = <tests.test_hf_api.HfApiPublicTest testMethod=test_model_info_with_security>
@with_production_testing
def test_model_info_with_security(self):
_api = HfApi()
model = _api.model_info(
repo_id=DUMMY_MODEL_ID,
revision=DUMMY_MODEL_ID_REVISION_ONE_SPECIFIC_COMMIT,
securityStatus=True,
)
self.assertEqual(
> getattr(model, "securityStatus"),
{"containsInfected": False, "infectionTypes": []},
)
E AttributeError: 'ModelInfo' object has no attribute 'securityStatus' we've seen this before, didn't we fix it? |
O changed the version to |
Sounds good, LGTM. Merging! cc @muellerzr I believe you had encountered this CI error in the past? |
Yeah, it just needs to be reran (not a fan of that of course). It's an issue on the db side IIRC. |
yes i'm aware of this server-side issue (flakyness on |
We're releasing 0.5, not 0.4.