Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guide for merging PRs #856

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Update contribution guide for merging PRs #856

merged 2 commits into from
Apr 28, 2022

Conversation

stevhliu
Copy link
Member

This PR updates the contribution guide based on conversation with @LysandreJik that we try not to have the author merge the PR anymore.

@stevhliu stevhliu requested a review from LysandreJik April 27, 2022 18:45
@LysandreJik LysandreJik requested a review from adrinjalali April 27, 2022 18:54
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 27, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevhliu , other than the nit LGTM :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@LysandreJik LysandreJik merged commit 627fdb2 into main Apr 28, 2022
@LysandreJik LysandreJik deleted the update-contrib branch April 28, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants