-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list_spaces to HfApi #889
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks to go in the right direction! I would suggest to add a test for this 😄
On the server API side, possible query params on that endpoint are:
relevant internal PR for the model/dataset linking Feel free to experiment with the API to see what it does! |
Should I be defining a new |
@osanseviero @LysandreJik can chime in but i don't think so |
It's useful, but definitely not necessary. Having |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me from a quick glance!
Thank you @cakiki!!
hmm so @osanseviero made me realize i was mistaken, I only meant that if you pass models or datasets in your query (as string or array of string), then they will also be returned as fields in the API output. Sorry about the incorrect information! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool PR! I left some suggestions 😄
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left some comments on the tests but otherwise looks almost ready to merge
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
Thank you @cakiki for the contribution!! 🔥 🔥 |
Yay it's very cool!! thanks |
First try; fixes #881. :-)
Reused the
SpaceInfo
class, but not sure that was the way to go because of unused fields:cc @osanseviero @LysandreJik