Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI enable codecov #893

Merged
merged 2 commits into from
Jun 9, 2022
Merged

CI enable codecov #893

merged 2 commits into from
Jun 9, 2022

Conversation

adrinjalali
Copy link
Contributor

This PR enables codecov reports on this repo.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@adrinjalali
Copy link
Contributor Author

The files are being uploaded:

https://app.codecov.io/gh/huggingface/huggingface_hub/pulls

This should be ready for a review/merge: @LysandreJik @osanseviero

@osanseviero osanseviero requested a review from LysandreJik June 3, 2022 07:32
LysandreJik
LysandreJik reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90,31%, that's quite nice, I didn't expect such a high number!

How can we do to have easy visibility on each PR? In the past we were working with comments, but I understand that's not your favored approach @adrinjalali.

@adrinjalali
Copy link
Contributor Author

A step is added to the CI list when it finishes, and it fails when it's not happy. We can start with that and then add the comments if we're not happy with how that works. WDYT?

@LysandreJik
Copy link
Member

Yes, that sounds good to me.

LysandreJik
LysandreJik approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adrinjalali
Copy link
Contributor Author

@osanseviero should we merge this one?

osanseviero
osanseviero approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very cool! Feel free to go ahead and merge 🔥

@adrinjalali adrinjalali merged commit 271ed15 into huggingface:main Jun 9, 2022
@adrinjalali
Copy link
Contributor Author

Let's see how it works and experiment.

@adrinjalali adrinjalali deleted the codecov branch June 9, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrinjalali @HuggingFaceDocBuilderDev @LysandreJik @osanseviero