-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display endpoint URL in whoami command #895
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Looks good to me, but I wonder if we shouldn't only print it when the endpoint is different to the default one. I think it would also warrant an explanation of what is being printed, something like:
WDYT? |
I'm offering to only print it when it's different to the default one, as otherwise it may be a bit weird:
My first reaction when seeing this is wondering why the devs left a random print statement in the code :) |
That's fine with me :) |
I've opened a PR on your PR here to move the print statement as I was mentioning in my comment above: juliensimon#1 Let me know if this works for you, I find it clearer this way but open to different opinions :) |
Move print statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a convenient way to check what hub endpoint you're logged on to (public hub, private hub, etc.):
The codebase has some informational messages with hard-coded references to huggingface.co. I've left these alone, maybe we should clean them up at some point.