Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding audio-to-audio widget. #95

Merged
merged 7 commits into from
Jun 16, 2021
Merged

adding audio-to-audio widget. #95

merged 7 commits into from
Jun 16, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Jun 9, 2021 •
edited
Loading

To be done

After #87
After #93
Before #94

@Narsil Narsil changed the base branch from main to open_widgets June 9, 2021 15:27
@Narsil Narsil requested a review from osanseviero June 9, 2021 15:28
Base automatically changed from open_widgets to main June 14, 2021 13:28
osanseviero
osanseviero reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick look it seems fine. Could you please sync now that the widget open sourcing is merged?

I'll take a final look afterwards

interfaces/Types.ts Outdated Show resolved Hide resolved
widgets/src/lib/InferenceWidget/InferenceWidget.svelte Outdated Show resolved Hide resolved
@osanseviero
Copy link
Contributor

@beurkinger probably interested in this :)

@Narsil Narsil force-pushed the open_widgets_audio_to_audio branch from 4fcc0fd to e21adf8 Compare June 15, 2021 08:36
@Narsil
Copy link
Contributor Author

Narsil commented Jun 15, 2021

Ping @osanseviero (was a simple rebase + cleanup, should be much easier to review).

@osanseviero osanseviero self-requested a review June 15, 2021 09:14
osanseviero
osanseviero approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks a lot!
Note that you will need to add this to moon-landing as well, they don't automatically sync at the moment.

julien-c
julien-c reviewed Jun 15, 2021
View reviewed changes
interfaces/Types.ts Outdated Show resolved Hide resolved
@julien-c
Copy link
Member

Looks good from quick glance, but tagging @jonashaag and @mpariente with whom we implemented the audio-source-separation widget, to get their feedback

Narsil and others added 2 commits June 15, 2021 14:15
@Narsil @julien-c
Update interfaces/Types.ts
d039123 
Co-authored-by: Julien Chaumond <julien@huggingface.co>
@Narsil @julien-c
Update widgets/src/lib/InferenceWidget/widgets/AudioToAudioWidget/Aud…
299cbf6 
…ioToAudioWidget.svelte

Co-authored-by: Julien Chaumond <julien@huggingface.co>
@jonashaag
Copy link

Thanks for tagging me, I don't have anything to say to this PR but added comments on a related one

@Narsil Narsil merged commit 2c0f464 into main Jun 16, 2021
@Narsil Narsil deleted the open_widgets_audio_to_audio branch June 16, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

@julien-c julien-c julien-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Narsil @osanseviero @julien-c @jonashaag