✨ create_commit: more user-friendly errors on HTTP 400 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBrandeis
requested review from
julien-c,
adrinjalali,
osanseviero and
LysandreJik
|
The documentation is not available anymore as the PR was closed or merged. |
adrinjalali
reviewed
Aug 2, 2022
There was a problem hiding this comment.
This looks nice, but it might cause some friction if users are catching those exceptions.
I'd suggest an exception class which inherits from ValueError and HTTPError so that existing user code would work.
The methods which can raise this exception can document it as ValueError, but if users are already catching HTTPError, their code wouldn't break after an upgrade.
WDYT?
|
That's a very valid point @adrinjalali, thanks for the suggestion! |
|
cc @Wauplin |
Wauplin
reviewed
Aug 2, 2022
Wauplin
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #962
This PR converts HTTP 400 errors from
/api/preuploadand/api/commitAPIs intoValueErrorsSuggestions/feedback welcome