Disable codecov + configure pytest FutureWarnings #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, I am personally in favor of code coverage in PRs. However since it's broken and it's less a priority to fix it, I find it preferable to disable it for now (and for what I understood everyone already agreed on Slack -or said nothing-) |
|
The documentation is not available anymore as the PR was closed or merged. |
osanseviero
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the CI, we currently run the tests with the
--covoption to get a code coverage report. However, as pointed out by @osanseviero in this PR (#925), it is broken at the moment and only check coverage of the tests themselves. It has apparently already been discussed here (internal url) and here (internal url). The purpose of the PR is to simply remove coverage for now as it is broken and give unreliable information. I will create a separate issue to fix it and enable it again (EDIT: this one #977).Also, this PR sets the
-Werror::FutureWarningflag by default. This should lead to less friction as contributors will run exactly the same tests locally and on CI.